Throttling reindex requests per node from reindex data stream api#125353
Closed
masseyke wants to merge 4 commits intoelastic:mainfrom
Closed
Throttling reindex requests per node from reindex data stream api#125353masseyke wants to merge 4 commits intoelastic:mainfrom
masseyke wants to merge 4 commits intoelastic:mainfrom
Conversation
Collaborator
|
Hi @masseyke, I've created a changelog YAML for you. |
…yke/elasticsearch into throttle-reindex-requests-per-node
Member
Author
|
I'm closing this one because the benefit we get is probably not worth the added complexity. We might revisit this if we start seeing real-world problems. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NOTE: This is currently a draft, created so that we can discuss whether the added complexity is worth the benefit we get from it. It is not ready for review.
We allow users to configure the number of indices we reindex in parallel from the reindex data stream API. It is possible that a user could set this to a very high value, and then swamp the cluster with reindex requests. This change makes it so that we send no more than 10 reindex requests to any node at a time. It builds on the work done in #125171.